feat(rest): add sigv4 retry configuration defaults#3063
Open
mrutunjay-kinagi wants to merge 2 commits intoapache:mainfrom
Open
feat(rest): add sigv4 retry configuration defaults#3063mrutunjay-kinagi wants to merge 2 commits intoapache:mainfrom
mrutunjay-kinagi wants to merge 2 commits intoapache:mainfrom
Conversation
Tommo56700
reviewed
Feb 18, 2026
| ) | ||
| ) | ||
| self._boto_session = boto3.Session( | ||
| region_name=get_first_property_value(self._properties, AWS_REGION), |
There was a problem hiding this comment.
Potentially this should also be aligned with the glue catalog? E.g. inclusion of profile name:
iceberg-python/pyiceberg/catalog/glue.py
Line 332 in 9687d08
Author
There was a problem hiding this comment.
Good call, agreed. I have aligned this with Glue by passing client.profile-name into the SigV4 boto3.Session initialization. I also added a regression test (test_sigv4_uses_client_profile_name) to lock this behavior. This is now pushed on this PR branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
When REST catalog uses SigV4 signing, retries were not configured on the mounted adapter. This change adds explicit retry defaults for signed REST requests and makes retry count configurable.
Changes:
rest.sigv4.max-retriescatalog property.GET,HEAD,OPTIONS) and common throttling/transient codes (429,500,502,503,504).Are these changes tested?
Yes.
test_sigv4_adapter_default_retry_config.test_sigv4_adapter_override_retry_config.Are there any user-facing changes?
Yes.
rest.sigv4.max-retries.