MINOR: Fix requests version conflict with ducktape in tests/setup.py#21415
Merged
chia7712 merged 1 commit intoapache:trunkfrom Feb 7, 2026
Merged
MINOR: Fix requests version conflict with ducktape in tests/setup.py#21415chia7712 merged 1 commit intoapache:trunkfrom
chia7712 merged 1 commit intoapache:trunkfrom
Conversation
omkreddy
approved these changes
Feb 6, 2026
chia7712
reviewed
Feb 7, 2026
| @@ -49,7 +49,7 @@ def run(self): | |||
| license="apache2.0", | |||
| packages=find_packages(), | |||
| include_package_data=True, | |||
| install_requires=["ducktape==0.12.0", "requests==2.32.4", "psutil==5.7.2", "pytest==8.3.3", "mock==5.1.0"], | |||
| install_requires=["ducktape==0.12.0", "requests>=2.31.0", "psutil==5.7.2", "pytest==8.3.3", "mock==5.1.0"], | |||
Member
There was a problem hiding this comment.
Is it worth updating ducktape to 0.13.0 in this PR?
Member
There was a problem hiding this comment.
With the update, we can bump the lower bound to 2.32.2
Contributor
Author
There was a problem hiding this comment.
Hi @chia7712, thanks for the suggestion.
Based on this note:
Line 42 in 200f389
We also need to update Docker, which would be a larger change and would require running the full test suite. We can pick this up later.
For now, this conflict is blocking Ducktape system test execution. If we fix this it will be easy to test ducktape 0.13.0 in future.
Member
There was a problem hiding this comment.
@tirthooo7 you are right. I've opened https://issues.apache.org/jira/browse/KAFKA-20153 to be a follow-up
chia7712
approved these changes
Feb 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix Python dependency conflict between
requestsandducktapethatprevents
kafkatestfrom being installed.Problem
The
tests/setup.pypinsrequests==2.32.4, butducktape==0.12.0internally requires
requests==2.31.0. This causes pip to fail with :This was introduced by dependabot PR #19940 which bumped
requestsfrom2.31.0 to 2.32.4 without checking ducktape's transitive dependencies.
Solution
Change
requests==2.32.4torequests>=2.31.0. This allows pip toinstall
requests==2.31.0(what ducktape needs) while still satisfyingthe version constraint.
Changes
tests/setup.py: Change strict pinrequests==2.32.4to flexiblerequests>=2.31.0Testing
✅ System-test-Kafka-Branch-Builder - [Workflow] [21/21 tests
passed]
https://confluent-open-source-kafka-branch-builder-system-test-results.s3-us-west-2.amazonaws.com/fix-cloud-tagging/2026-02-06--001.7f5b8f9a-4837-486a-864c-b5ad3b17391f--1770366328--confluentinc--fix-cloud-tagging--4b6335ab0f/report.html
tests/kafkatest/tests/client/client_compatibility_produce_consume_test.pyNotes
This is a minimal fix. An alternative would be upgrading to
ducktape==0.13.0which requiresrequests==2.32.2, but thatintroduces more changes and potential risk.
Reviewers: Manikumar Reddy manikumar.reddy@gmail.com, Chia-Ping Tsai
chia7712@gmail.com