fix: correct boolean parsing of pagination desc header in list_items#621
Merged
fix: correct boolean parsing of pagination desc header in list_items#621
Conversation
bool() on a string header value returns True for any non-empty string, including the string "false". This caused the desc field in ListPage to always be True. Use explicit string comparison instead. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
vdusek
added
bug
vdusek
added
bug
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #621 +/- ##
=======================================
Coverage 76.02% 76.02%
=======================================
Files 42 42
Lines 2482 2482
=======================================
Hits 1887 1887
Misses 595 595
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Feb 17, 2026
Contributor
Pijukatel
left a comment
Pijukatel
left a comment
There was a problem hiding this comment.
This fix would be nice with a test
Verify that the x-apify-pagination-desc header is correctly parsed as a boolean using string comparison, covering both sync and async clients with various casing (true/True/TRUE/false/False/FALSE). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
github-actions
bot
added
the
tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bool(response.headers['x-apify-pagination-desc'])always returnsTruefor any non-empty string, including"false"descfield inListPagefromlist_itemswas alwaysTrueregardless of the actual API response.lower() == 'true'(both sync and async variants)Test plan
list_items(desc=False)returnsListPagewithdesc=False🤖 Generated with Claude Code