This repository was archived by the owner on Dec 29, 2021. It is now read-only.
Feature/86/run using active compilation profile#97
Merged
epage merged 1 commit intoassert-rs:masterfrom Mar 27, 2018
Merged
Conversation
Collaborator
|
Looks good! Do you mind squashing your commits? If you do so, let me know when you push again because force pushes don't cause notifications to be sent. |
Run Rustfmt. Issue assert-rs#86
707417b to
141f59e
Compare
Contributor
Author
|
Hopefully I'm not noob 😄, I assume "squash commits" means squash all of them into 1 commit. Pushed! |
Collaborator
Yup, thats what I meant. More generally, the desire is to clean up commit history (re-arrange or squash commits as needed) to give us a clean commit history. This especially helpful when someone presents a PR with a clean history but then we iterate on some aspects of it, causing commits that should be cleaned up. I was just being more specific in your case because all you needed was to squash :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #86
cargo testsucceedscargo +nightly clippysucceedscargo +nightly fmtsucceeds