Conversation
|
Ok, even without trying, I think the toggle is a bad idea. Because seeing the toggle switch when clicking on hunk headers or lines probably feels pretty irritating. Also, I forgot that the file name is shown in the status-bar, in case it's long and you can't read it in the tab. @kuychaco So not sure. We can also close this again and come back to it if we really think it's necessary. |
|
Hmm those are all good points @simurai. I do like the open file and view staged/unstaged version affordances. We could also add buttons for stage/unstage all, discard all, and undo discard. What do you think about keeping the bar just for these? |
|
Okay, I pulled the file diff header into #487, took out the toggle, wired up everything and added a I'll go ahead and close this for now and we can revisit the hunk/line mode indication at a later point if we feel the need to. |

This adds a header to the FilePatch view. It could be used to add some more infos or buttons.
Concerns
Overkill? For example the toggle might makes it feel more complicated than it should be. Having to pay attention to what mode you're in. Switching between staged/unstaged changes without having to find it in the list sounds useful though.