fix: respect all config file provided width values#793
Open
sivel wants to merge 1 commit intocharmbracelet:masterfrom
Open
fix: respect all config file provided width values#793sivel wants to merge 1 commit intocharmbracelet:masterfrom
sivel wants to merge 1 commit intocharmbracelet:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This PR aims to address #752 where width values specified in the config file below 80 or above 120 are effectively ignored, including the special value of
0.To do this, the default value written to the config file is set to
0to mirror the viper default forwidth, and the special casing to restrict with width when not user specified has been removed. Users with a pre-existing config file will still maintain the previously set value of80, and should still see the previous behavior.Fixes #752
Related issue/discussion: #752
Checklist before requesting a review
CONTRIBUTING.mdIf this is a feature