inverted the relationship between expanded macros and tokens#305
Draft
firewave wants to merge 2 commits intodanmar:masterfrom
Draft
inverted the relationship between expanded macros and tokens#305firewave wants to merge 2 commits intodanmar:masterfrom
firewave wants to merge 2 commits intodanmar:masterfrom
Conversation
Collaborator
Author
|
Currently just a hack but tests still pass. And this fixes https://trac.cppcheck.net/ticket/11885. |
Collaborator
Author
|
I am pretty sure the hack is all wrong (too warm to think 🫠). But I think the idea is sound 🤞. Definitely needs way more tests first. |
967b360 to
a2e3610
Compare
Collaborator
Author
|
These changes are better. They pass all the tests in simplecpp and Cppcheck. They do not fix that upstream issue as it hits something different now. Before After Clang 15 |
Collaborator
Author
|
Unfortunately these changes case a big regression to the example in #96. Before After |
Collaborator
Author
|
The clang-tidy false negative which was unearthed by this was reported upstream as llvm/llvm-project#64955. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of duplicating the macro references into each token we should just keep references to the tokens in the macros.