direct: plan: when action=delete, do not fail deps on read errors#4462
Open
direct: plan: when action=delete, do not fail deps on read errors#4462
Conversation
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
Collaborator
|
Commit: d0ca005
19 interesting tests: 7 KNOWN, 5 SKIP, 4 RECOVERED, 3 flaky
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
It's intended to work like that: if we plan to delete the resource we're reading it to see in case it already deleted. If we get error during read, we should delegate to resource's DoDelete() method - some of them are intentionally no-ops, so they will succeed.
Fixes acceptance/bundle/resources/permissions/jobs/destroy_without_mgmtperms/with_permissions that was failing for a while.