Skip to content

Remove note stating that DATAS setting doesn't have a specific MSBuild property#51540

Merged
gewarren merged 1 commit intodotnet:mainfrom
KeterSCP:datas-msbuild
Feb 6, 2026
Merged

Remove note stating that DATAS setting doesn't have a specific MSBuild property#51540
gewarren merged 1 commit intodotnet:mainfrom
KeterSCP:datas-msbuild

Conversation

@KeterSCP
Copy link
Contributor

@KeterSCP KeterSCP commented Feb 6, 2026

Summary

DATAS does have it's own MSBuild property. It is even listed in the table above:

image

Internal previews

📄 File 🔗 Preview link
docs/core/runtime-config/garbage-collector.md Runtime configuration options for garbage collection

@KeterSCP KeterSCP requested review from a team and gewarren as code owners February 6, 2026 15:23
Copilot AI review requested due to automatic review settings February 6, 2026 15:23
@dotnetrepoman dotnetrepoman bot added this to the February 2026 milestone Feb 6, 2026
@dotnet-policy-service dotnet-policy-service bot added dotnet-fundamentals/svc community-contribution Indicates PR is created by someone from the .NET community. labels Feb 6, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the GC configuration documentation to remove an incorrect note in the DATAS section that claimed the setting doesn’t have a dedicated MSBuild property, even though the table lists one.

Changes:

  • Removed the runtimehostconfigurationoption include under “Enabling or disabling DATAS” because it incorrectly states no specific MSBuild property exists for the setting.

Copy link
Contributor

@gewarren gewarren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @KeterSCP!

@gewarren gewarren enabled auto-merge (squash) February 6, 2026 16:20
@gewarren gewarren merged commit d592992 into dotnet:main Feb 6, 2026
17 of 18 checks passed
@KeterSCP KeterSCP deleted the datas-msbuild branch February 6, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community-contribution Indicates PR is created by someone from the .NET community. dotnet-fundamentals/svc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants