Add missing exports for try_cast, bitwise_not, and label#1748
Open
veeceey wants to merge 1 commit intofastapi:mainfrom
Open
Add missing exports for try_cast, bitwise_not, and label#1748veeceey wants to merge 1 commit intofastapi:mainfrom
veeceey wants to merge 1 commit intofastapi:mainfrom
Conversation
These functions were defined in sqlmodel/sql/expression.py but not exported in sqlmodel/__init__.py, making them inaccessible to users. Added exports for: - try_cast: SQL TRY_CAST operation for safe type casting - bitwise_not: Bitwise NOT operation - label: Create labeled expressions This makes the API more complete and consistent with SQLAlchemy's functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added missing exports for three functions that were defined in
sqlmodel/sql/expression.pybut not exported insqlmodel/__init__.py, making them inaccessible to users.Changes
Added exports for:
try_cast: SQL TRY_CAST operation for safe type casting (returns NULL on cast failure instead of raising an error)bitwise_not: Bitwise NOT operation for integer columnslabel: Create labeled expressions for query resultsWhy
These functions are fully implemented in
sqlmodel/sql/expression.pybut were missing from the public API. Users who needed these operations had to import directly from the internal module or use SQLAlchemy directly.Test plan
from sqlmodel import try_cast, bitwise_not, labelRelated
This makes SQLModel's API more complete and consistent with SQLAlchemy's functionality.
Example usage after this change: