fix(node-core): passthrough node-cron context#17835
Merged
andreiborza merged 1 commit intogetsentry:developfrom Dec 11, 2025
Merged
fix(node-core): passthrough node-cron context#17835andreiborza merged 1 commit intogetsentry:developfrom
andreiborza merged 1 commit intogetsentry:developfrom
Conversation
4e0cb52 to
6f554fa
Compare
chargome
approved these changes
Oct 1, 2025
Member
chargome
left a comment
There was a problem hiding this comment.
Makes sense to me, should we add a dev dep for this @andreiborza ?
Member
|
Yea, we can add that in this PR. |
Contributor
Author
|
tbh it might be a bit harder, given this wrapper already wraps incorrectly and doesn't support node-cron fully, e.g. string referring to a file instead of a callback. however, just for fun, perhaps it would be more accurate to do |
Contributor
Author
|
maybe a different style of wrapper would be more accurate that passed through without manipulation and would add event listeners, leaving node-cron to fully handle the execution. although I'm not sure if that would work with how |
Member
|
Right, okay then let's keep it as is. Thanks for the contribution! |
nicohrubec
added a commit
that referenced
this pull request
Dec 11, 2025
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #17835 Co-authored-by: andreiborza <168741329+andreiborza@users.noreply.github.com> Co-authored-by: Nicolas Hrubec <nico.hrubec@sentry.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
- [ ] If you've added code that should be tested, please add tests.yarn lint) & (yarn test).node-cron passes context to the functions which this integration does not.
the types here seem to be largely irrelevant as consumers just get the actual node-cron type. however, it might be better to install node-cron as a devdependency and then import and use types from it to get consistency