feat(core): Apply scope attributes to logs

[Lms24]

This PR adds support for scope attributes on logs. For now, only primitive attribute values are supported despite type declarations of Scope.setAttribute(s) also allowing array attribute values. The reason for this limited support is that Relay still discards array attribute values. Therefore, our serialization strategy for now is:

• As previously: We continue to stringify non-primitive values for log/metric attributes
• New: We apply only primitive scope attributes on logs/metrics and discard any non-primitive values
• Future: We'll uniformly handle arrays (properly) in v11 (i.e. no longer stringify them), i.e. treat all attributes equally.

Usage Example

Sentry.getCurrenScope().setAttribute('user_is_admin', true);

Sentry.logger.info(`user ${user.id} logged in`, { activeSince: 100 });
Sentry.logger.warn('unsupported version');

// `user_is_admin` attribute is applied to both logs

Some behavior notes:

• Scope attributes are merged from all active scopes (current, isolation, global scopes) when the log is captured
• Log attributes have precedence over scope attributes

closes #18159

[github-actions]

size-limit report 📦

Path	Size	% Change	Change
@sentry/browser	24.82 kB	+0.07%	+16 B 🔺
@sentry/browser - with treeshaking flags	23.32 kB	+0.08%	+17 B 🔺
@sentry/browser (incl. Tracing)	41.59 kB	+0.05%	+18 B 🔺
@sentry/browser (incl. Tracing, Profiling)	46.2 kB	+0.05%	+20 B 🔺
@sentry/browser (incl. Tracing, Replay)	80.18 kB	+0.03%	+21 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags	69.91 kB	+0.03%	+17 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas)	84.87 kB	+0.03%	+19 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback)	97.1 kB	+0.03%	+22 B 🔺
@sentry/browser (incl. Feedback)	41.54 kB	+0.06%	+21 B 🔺
@sentry/browser (incl. sendFeedback)	29.51 kB	+0.07%	+18 B 🔺
@sentry/browser (incl. FeedbackAsync)	34.5 kB	+0.06%	+19 B 🔺
@sentry/react	26.54 kB	+0.08%	+19 B 🔺
@sentry/react (incl. Tracing)	43.79 kB	+0.04%	+17 B 🔺
@sentry/vue	29.29 kB	+0.07%	+18 B 🔺
@sentry/vue (incl. Tracing)	43.41 kB	+0.05%	+21 B 🔺
@sentry/svelte	24.84 kB	+0.07%	+16 B 🔺
CDN Bundle	27.25 kB	+0.09%	+24 B 🔺
CDN Bundle (incl. Tracing)	42.24 kB	+0.05%	+20 B 🔺
CDN Bundle (incl. Tracing, Replay)	78.95 kB	+0.03%	+20 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback)	84.42 kB	+0.03%	+23 B 🔺
CDN Bundle - uncompressed	80.06 kB	+0.05%	+34 B 🔺
CDN Bundle (incl. Tracing) - uncompressed	125.41 kB	+0.03%	+34 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed	241.94 kB	+0.02%	+34 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed	254.71 kB	+0.02%	+34 B 🔺
@sentry/nextjs (client)	46.01 kB	+0.04%	+17 B 🔺
@sentry/sveltekit (client)	41.97 kB	+0.05%	+19 B 🔺
@sentry/node-core	51.61 kB	+0.04%	+16 B 🔺
@sentry/node	161.5 kB	+0.02%	+18 B 🔺
@sentry/node - without tracing	93.05 kB	+0.03%	+19 B 🔺
@sentry/aws-serverless	108.56 kB	+0.02%	+17 B 🔺

View base workflow run

[github-actions]

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario	Requests/s	% of Baseline	Prev. Requests/s	Change %
GET Baseline	9,218	-	8,607	+7%
GET With Sentry	1,698	18%	1,699	-0%
GET With Sentry (error only)	6,082	66%	5,911	+3%
POST Baseline	1,207	-	1,176	+3%
POST With Sentry	593	49%	589	+1%
POST With Sentry (error only)	1,066	88%	1,039	+3%
MYSQL Baseline	3,327	-	3,259	+2%
MYSQL With Sentry	458	14%	449	+2%
MYSQL With Sentry (error only)	2,671	80%	2,664	+0%

View base workflow run

[Lms24]

UPDATE: See PR description for updated behaviour

OK, so we still have 2 problems and a minor inconvenience here:

1. Relay still drops array attributes. Our scope attribute API supports adding arrays but these attributes would simply not make it to Sentry. This is not really a problem for scope attributes (since we don't document them yet) but if we switch log attributes to the same serialization logic as for scope attributes, array attributes on logs would no longer be stringified but also dropped.
2. Suppose Relay supports array attributes, we'd still have a somewhat breaking change in that log array attributes would no longer be stringified but sent as arrays. I don't think this is the end of the world but we should keep this in mind and tell the logs folks about it
3. (minor inconvenience) units are also dropped by Relay. Again only a proble for scope attributes for now but we could easily add support for log attributes as well. The values of the attributes with units are still forwarded correctly.

[Lms24]

To at least offer partial support, we settled on only serializing primitive, and discarding non-primitive scope attribute values. I update the PR and the PR description accordingly.

[Lms24]

Since we have a fallback parameter in attributeValueToTypedAttributeValue, we can get rid of this logic. For now the bundle size savings are minimal but once we migrate logs to the new unified function, it should pay off.

[Lms24]

This was still missing in #18165

[chargome]

Looks good!