chore(tests): Added test variant flag#18458
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a --variant flag to the E2E test runner, enabling developers to run specific test variants (e.g., different Next.js versions) against individual test applications.
- Adds
--variantflag parsing to support both--variant=<name>and--variant <name>formats - Implements variant matching logic that reads variant configurations from test application
package.jsonfiles - Updates documentation with usage examples and explanation of variant matching behavior
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
dev-packages/e2e-tests/run.ts |
Adds interfaces for variant configuration, implements variant flag parsing and matching logic, integrates variant build commands into test execution flow |
dev-packages/e2e-tests/README.md |
Documents the new --variant flag usage with examples and explains the case-insensitive partial matching behavior |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![cursor[bot]](https://avatars-githubusercontent-com-gh.computerqwq.top/in/1210556?s=60&v=4){kind=small}
![sentry[bot]](https://avatars-githubusercontent-com-gh.computerqwq.top/in/12637?s=60&v=4){kind=small}
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
logaretm
force-pushed
the
awad/variant-test-runner-script
branch
from
0366df2 to
11ce429
Compare
logaretm
force-pushed
the
awad/variant-test-runner-script
branch
from
11ce429 to
86126e5
Compare
logaretm
changed the title
Lms24
approved these changes
Dec 11, 2025
| yarn test:run <app-name> --variant <variant-name> | ||
| ``` | ||
|
|
||
| Variant name matching is case-insensitive and partial. For example, `--variant 13` will match `nextjs-pages-dir (next@13)` if a matching variant is present in the test app's `package.json`. |
Member
There was a problem hiding this comment.
l: can we show an example of the package.json entry? I'm aware this existed before but I think it's worth mentioning it more explicitly in the readme
Member
Author
There was a problem hiding this comment.
Makes sense, I added an example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been running a lot of Next.js tests and needed to run specific variants against my changes, so I made these changes to our test runner script and thought to share it with everyone.
Closes #18459 (added automatically)