fix(tracing): Set span operations for AI spans with model ID only#18471
Merged
RulaKhaled merged 1 commit intodevelopfrom Dec 11, 2025
Conversation
| const aiModelProvider = attributes[AI_MODEL_PROVIDER_ATTRIBUTE]; | ||
| if (typeof aiModelId !== 'string' || typeof aiModelProvider !== 'string' || !aiModelId || !aiModelProvider) { | ||
| if (typeof aiModelId !== 'string' || !aiModelId) { | ||
| return; |
There was a problem hiding this comment.
Bug: Missing regression test for the fix (Bugbot Rules)
This is flagged because it was mentioned in the rules file. This is a fix PR that relaxes the validation to only require ai.model.id instead of both ai.model.id and ai.model.provider. The rules specify that fix PRs should include at least one test that tests the regression being fixed (a test that failed before the fix and passes after). There's no test in this PR that verifies spans without the provider attribute are now processed correctly.
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
nicohrubec
approved these changes
Dec 11, 2025
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where VercelAI integration span operations were not being set correctly because the validation was too restrictive. I relaxed the condition to only require
ai.model.idattribute instead of bothai.model.idandai.model.provideras provider attribute is optional and may not always be present on spansCloses https://linear.app/getsentry/issue/JS-1280