fix(feedback): Fix cases where the outline of inputs were wrong#18647
Merged
fix(feedback): Fix cases where the outline of inputs were wrong#18647
Conversation
When the integration had "colorScheme: "dark"," then we include css for both light and dark mode. But some properties, like `outline` don't need to be specified, the system does it for us. However, setting `color-scheme: only light` meant that the light-mode outlines were used in all cases. This changes things so that we have the correct values for `color-scheme` if a specific value is picked. This ensures that the `outline` and `:focus` colors set by the system are correct in all cases. Test Plan: I tested with my system set to each of: light, dark, automatic And then with the integration setting set to each of: `colorScheme: 'light'`, `colorScheme: 'dark'` and `colorScheme: 'system'`. To test i just opened up the feedback widget and clicked to focus an input box.
ryan953
requested review from
a team,
Lms24 and
andreiborza
and removed request for
a team
ryan953
commented
Dec 31, 2025
| }` | ||
| : '' | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
This was an extra closing brace doing nothing good nor bad.
I spotted it in the output though, we don't need it.
![cursor[bot]](https://avatars-githubusercontent-com-gh.computerqwq.top/in/1210556?s=60&v=4){kind=small}
| }` | ||
| : '' | ||
| } | ||
| } |
There was a problem hiding this comment.
Fix PR missing automated regression test (Bugbot Rules)
Per the review rules: when reviewing a fix PR, check if it includes at least one unit, integration, or e2e test that tests the regression being fixed. This fix for color-scheme behavior doesn't appear to include any automated test. While CSS visual testing can be challenging and the PR includes manual testing with before/after screenshots, adding an automated test that verifies the generated CSS output for different colorScheme values ('light', 'dark', 'system') would help prevent future regressions.
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The integration was using
"colorScheme: "dark"we include css only dark mode. But some properties, likeoutlinewere not specified, the system does a good job by default. However, addingcolor-scheme: only lightinto the css meant that the light-mode outlines were used in all cases, even when we asked for dark mode.This changes things so that we have the correct values for
color-schemeif a specific value is picked. This ensures that theoutlineand:focuscolors set by the system are correct in all cases.Test Plan
I tested with my system set to each of: light, dark, automatic And then with the integration setting set to each of:
colorScheme: 'light',colorScheme: 'dark'andcolorScheme: 'system'. To test i just opened up the feedback widget and clicked to focus an input box.Screenshots