ref(core): Streamline and test browserPerformanceTimeOrigin#18708
Merged
ref(core): Streamline and test browserPerformanceTimeOrigin#18708
browserPerformanceTimeOrigin#18708Conversation
Contributor
size-limit report 📦
|
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
Lms24
commented
Jan 7, 2026
Lms24
commented
Jan 7, 2026
timfish
approved these changes
Jan 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A conversation about browser
performance.timeOrigin(cc @timfish) made me take a look at our implementation how to get the most accurate time origin. I'm fairly sure this implementation has a few flaws we should fix but for the scope of this PR I decided to add test coverage and apply some slight bundle size savings first, before tackling them.Specifically, this PR:
Blocked on major: We can remove an entire branch of this code, if we decide to drop Safari 14 support (opened #18707 to track)