fix(core): Subtract performance.now() from browserPerformanceTimeOrigin fallback#18715
Merged
fix(core): Subtract performance.now() from browserPerformanceTimeOrigin fallback#18715
performance.now() from browserPerformanceTimeOrigin fallback#18715Conversation
Contributor
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
logaretm
approved these changes
Jan 7, 2026
timfish
approved these changes
Jan 7, 2026
Lms24
added a commit
that referenced
this pull request
Jan 8, 2026
#18719) In `browserPerformanceTimeOrigin`, we test how reliable `performance.timeOrigin` (or its predecessor) is by comparing its timestamp against `performance.now() - Date.now()`. If the delta is larger than 1h, we take the fallback rather than `performance.timeOrigin`. This PR now makes the reliability check more strict by decreasing the time window from 1h to just 5 minutes. This _should_ catch time drift more often. Now that we improved the fallback via #18715, I think we can give this a shot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a "bug" where we previously returned just
Date.now()as a fallback for getting the timeOrigin if more preciseperformance.timeOriginorperformance.timing.navigationStartwere not available or unreliable.This fix now subtracts
performance.now()fromDate.now()which should make the fallback more accurate.Closes #18716 (added automatically)