fix(web-vitals): Add error handling for invalid object keys in WeakMap#18809
Merged
fix(web-vitals): Add error handling for invalid object keys in WeakMap#18809
WeakMap#18809Conversation
![cursor[bot]](https://avatars-githubusercontent-com-gh.computerqwq.top/in/1210556?s=60&v=4){kind=small}
| // --- START Sentry-custom code (try/catch wrapping) --- | ||
| // Fix for cases where identityObj is not a valid key for WeakMap (sometimes a problem in Safari) | ||
| // Just return a new instance without caching it in instanceMap | ||
| return new ClassObj(); |
There was a problem hiding this comment.
Missing test for fix PR per review rules
Low Severity · Bugbot Rules
Per the review rules: "When reviewing a fix PR, check if the PR includes at least one unit, integration or e2e test that tests the regression this PR fixes." This fix PR adds error handling for invalid WeakMap keys in Safari but the diff contains no accompanying test to verify the fix works correctly. A test that simulates the Safari TypeError scenario would help prevent regressions.
JPeer264
approved these changes
Jan 14, 2026
| return instanceMap.get(identityObj)! as T; | ||
| } catch (e) { | ||
| // --- START Sentry-custom code (try/catch wrapping) --- | ||
| // Fix for cases where identityObj is not a valid key for WeakMap (sometimes a problem in Safari) |
Member
There was a problem hiding this comment.
l: Is this issue easily reproducible? If so it'd be nice if we can somehow add a E2E test, if not I'm fine as is
Contributor
size-limit report 📦
|
Lms24
approved these changes
Jan 14, 2026
Member
Lms24
left a comment
Lms24
left a comment
There was a problem hiding this comment.
Thanks for fixing! As discussed, it's not ideal that we can't repo this but I think in this case, let's merge and release it and check back with the affected customer if it fixes the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A customer experienced the following issue on iOS Safari 18.6.2:
TypeError: WeakMap keys must be objects or non-registered symbols.The culprit is probably in web vitals
initUniquefunction (which is vendored in).This fix adds a try/catch to handle edge cases where invalid keys are passed to WeakMap, returning a new instance without caching when validation fails.
Closes #18810 (added automatically)