feat(core): Support new client discard reason invalid#18901
Conversation
node-overhead report 🧳Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.
|
0f2b3fa to
c2139be
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| | 'buffer_overflow' | ||
| | 'ignored'; | ||
| | 'ignored' | ||
| | 'invalid'; |
There was a problem hiding this comment.
Missing test for new feature
Medium Severity · Bugbot Rules
This feat PR adds the 'invalid' discard reason but includes no integration or E2E tests demonstrating its usage. The new reason type is defined but never used or tested anywhere in the codebase. The PR review rules require at least one integration or E2E test for feature PRs to verify the new functionality works as expected.
This new reason can be used when the client drops telemetry items due to failing internal validation (e.g. dropping replays that contain invalid session times)
ref #18316
depends on getsentry/snuba#7654
closes https://linear.app/getsentry/issue/FE-690/update-js-sdk-to-support-client-discard-invalid