feat(nuxt): Don't run source maps related code on Nuxt "prepare"#18936
Merged
feat(nuxt): Don't run source maps related code on Nuxt "prepare"#18936
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stumbled upon this while working on something else. The source map related code was always executed on the package manager's
installcommand and asnuxi prepareruns onpostinstall. This step is only important for generating the types, so we can skip all source map related things here so this only runs during the actual build.I also changed the console log a bit so it's more clear what we are doing.
Nuxt docs: https://nuxt.com/docs/4.x/api/commands/prepare
Closes #18937 (added automatically)