fix(nuxt): include sentry.config.server.ts in nuxt app types#18971
Merged
s1gr1d merged 1 commit intogetsentry:developfrom Jan 26, 2026
Merged
fix(nuxt): include sentry.config.server.ts in nuxt app types#18971s1gr1d merged 1 commit intogetsentry:developfrom
s1gr1d merged 1 commit intogetsentry:developfrom
Conversation
3 tasks
![cursor[bot]](https://avatars-githubusercontent-com-gh.computerqwq.top/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
packages/nuxt/src/module.ts
Outdated
| // Should be relative to `root/.nuxt` | ||
| const relativePath = path.relative(nuxt.options.buildDir, serverConfigFile); | ||
| tsConfig.include.push(relativePath); | ||
| }); |
There was a problem hiding this comment.
Fix PR lacks regression test per review rules
Low Severity · Bugbot Rules
This fix PR doesn't include any tests, which violates the specified review rules. The rules state that fix PRs require at least one unit, integration, or e2e test that tests the regression being fixed. While the PR author noted "Not sure how this could be tested tho, since it is purely types," testing that the prepare:types hook is registered and modifies tsConfig.include correctly would be valuable.
nicohrubec
pushed a commit
that referenced
this pull request
Jan 26, 2026
This PR adds the external contributor to the CHANGELOG.md file, so that they are credited for their contribution. See #18971 Co-authored-by: s1gr1d <32902192+s1gr1d@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The #17830 fixes the error explained in #17781 only for the sentry.client.config.ts but the error still exists for the sentry.server.config.ts.
With this PR we add the sentry.config.server.ts to the auto generated tsconfig by extending the types via the prepare:types hook.
This allows useRuntimeConfig to be properly typed in the root sentry.server.config.ts, or where ever the client file is found.
Not sure how this could be tested tho, since it is purely types.