Skip to content

Conversation

@keithamus
Copy link
Contributor

@keithamus keithamus commented May 6, 2022

As groundwork for 2.0, this adds a "marks" feature.

Marks are a simpler form of property Decorators which comply with the upcoming decorators standard, but are still compatible with TypeScript property decorators. This extracts a useful utility for making Catalyst extensible by extracting a primitive.

Right now @attr and @target do not use Marks, but in 2.0 they will.

This isn't exported from index.js so is inert, just extra package weight for 1.0 releases, but has no runtime impact.

@keithamus keithamus requested a review from a team as a code owner May 6, 2022 18:22
@keithamus keithamus requested a review from srt32 May 6, 2022 18:22
@keithamus keithamus enabled auto-merge May 6, 2022 18:22
Copy link
Contributor

@koddsson koddsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@keithamus keithamus merged commit ae48275 into main May 6, 2022
@keithamus keithamus deleted the marks branch May 6, 2022 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants