wrong urls for prev and next links#274
Merged
keithamus merged 2 commits intogithub:mainfrom Aug 17, 2022
Merged
Conversation
added 2 commits
August 16, 2022 21:46
keithamus
approved these changes
Aug 17, 2022
Contributor
keithamus
left a comment
keithamus
left a comment
There was a problem hiding this comment.
Great catch! I missed this too when checking it locally.
Thanks for the followup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I made a mistake on the previous and next links button PR by forgetting the base url which works in dev mode but not on GitHub Pages. It should be fixed now as I copied from the links on the sidebar (and it still works in local). First OSS bug :)