Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes binary file corruption in the get_file_contents tool by improving content-type detection logic to properly differentiate between text and binary content types.
- Replaced broad application/* prefix matching with specific text content type detection
- Added comprehensive test coverage for PDF binary file handling
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pkg/github/repositories.go | Updated content-type detection logic to properly identify text vs binary content |
| pkg/github/repositories_test.go | Added test case for PDF file retrieval to verify binary content handling |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
issei-m
pushed a commit
to issei-m/github-mcp-server
that referenced
this pull request
Nov 14, 2025
* tighten content filtering logic * add pdf retrieval test case * add application/xml check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes binary file corruption in the
get_file_contentstool by tightening content-type detection logic.Closes: #1168