Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR renames the WriteLabel function and tool to LabelWrite to improve naming consistency. The change affects both the function name and the tool's identifier.
- Renamed function from
WriteLabeltoLabelWrite - Updated tool name from "write_label" to "label_write"
- Updated all references and documentation accordingly
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pkg/github/tools.go | Updated function calls to use new LabelWrite name |
| pkg/github/labels_test.go | Updated test function calls and expected tool name |
| pkg/github/labels.go | Renamed function and updated translation keys |
| pkg/github/toolsnaps/label_write.snap | Updated snapshot with new tool name |
| README.md | Reorganized documentation to reflect new tool name ordering |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Comment on lines
+246
to
+248
| mcp.WithDescription(t("TOOL_LABEL_WRITE_DESCRIPTION", "Perform write operations on repository labels. To set labels on issues, use the 'update_issue' tool.")), | ||
| mcp.WithToolAnnotation(mcp.ToolAnnotation{ | ||
| Title: t("TOOL_WRITE_LABEL_TITLE", "Write operations on repository labels."), | ||
| Title: t("TOOL_LABEL_WRITE_TITLE", "Write operations on repository labels."), |
There was a problem hiding this comment.
The translation keys have been updated from TOOL_WRITE_LABEL_* to TOOL_LABEL_WRITE_* but there's no evidence that the corresponding translation files have been updated. This could result in missing translations falling back to the default English text.
kerobbi
approved these changes
Oct 9, 2025
issei-m
pushed a commit
to issei-m/github-mcp-server
that referenced
this pull request
Nov 14, 2025
* rename tooling * fix double tool
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As we named
pull_request_readandpull_request_review_writewe are sticking to that format as the read write attribute makes more sense as a suffix for better text search and formatting.And the label_write tool was accidentally added to issues too.