Conversation
f312b18 to
e6fa90d
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes URL parsing for GitHub Enterprise Server (GUES) instances with subdomain isolation enabled. The fix addresses issues where the server was incorrectly constructing URLs for raw content and upload APIs when subdomain isolation was configured.
- Adds automatic detection of subdomain isolation by probing the raw subdomain endpoint
- Updates URL construction logic to use subdomain-based URLs when isolation is detected
- Improves error messages to provide better context when raw API calls fail
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| internal/ghmcp/server.go | Implements subdomain isolation detection and conditional URL formatting logic |
| pkg/github/repositories.go | Captures raw API response codes and improves error messaging for better debugging context |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
Great work, thank you! Love the new feedback for LLMs. |
omgitsads
approved these changes
Oct 15, 2025
issei-m
pushed a commit
to issei-m/github-mcp-server
that referenced
this pull request
Nov 14, 2025
* adding better response * adding check for subdomain isolation and return raw resp for better better llm response * adding subdomain for uploads too * remove unnecessary comments * better error message * fix linter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issues in GHES when subdomain isolation is enabled.
PR introduces:
func newGHESHost(hostname string) (apiHost, error)get_file_contentsto return better fallback messageCloses:
get_file_contentsis not working properly (Path did not point to a file or directory, but resolved git ref) #864