Skip to content

Use request context instead of context.Background() in PR review tools #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kerobbi merged 2 commits into from
Feb 3, 2026
Merged

Use request context instead of context.Background() in PR review tools #1948

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
037e6fc
replace context.Background()
kerobbi Feb 3, 2026
17f34e9
Merge branch 'main' into fix-ctx-propagation
kerobbi Feb 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pkg/github/pullrequests.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1502,7 +1502,7 @@ func SubmitPendingPullRequestReview(ctx context.Context, client *githubv4.Client
"prNum": githubv4.Int(params.PullNumber),
}

if err := client.Query(context.Background(), &getLatestReviewForViewerQuery, vars); err != nil {
if err := client.Query(ctx, &getLatestReviewForViewerQuery, vars); err != nil {
return ghErrors.NewGitHubGraphQLErrorResponse(ctx,
"failed to get latest review for current user",
err,
Expand Down Expand Up @@ -1587,7 +1587,7 @@ func DeletePendingPullRequestReview(ctx context.Context, client *githubv4.Client
"prNum": githubv4.Int(params.PullNumber),
}

if err := client.Query(context.Background(), &getLatestReviewForViewerQuery, vars); err != nil {
if err := client.Query(ctx, &getLatestReviewForViewerQuery, vars); err != nil {
return ghErrors.NewGitHubGraphQLErrorResponse(ctx,
"failed to get latest review for current user",
err,
Expand Down Expand Up @@ -1761,7 +1761,7 @@ func AddCommentToPendingReview(t translations.TranslationHelperFunc) inventory.S
"prNum": githubv4.Int(params.PullNumber),
}

if err := client.Query(context.Background(), &getLatestReviewForViewerQuery, vars); err != nil {
if err := client.Query(ctx, &getLatestReviewForViewerQuery, vars); err != nil {
return ghErrors.NewGitHubGraphQLErrorResponse(ctx,
"failed to get latest review for current user",
err,
Expand Down
Loading