Merged
Conversation
Signed-off-by: Liam Beguin <liambeguin@gmail.com>
Signed-off-by: Liam Beguin <liambeguin@gmail.com>
Signed-off-by: Liam Beguin <liambeguin@gmail.com>
Contributor
Author
|
Hi, I managed to test it locally but I'm having trouble with the test case... $ virtualenv -p python3 venv
$ source venv/bin/activate
$ pip install .
$ rm -rf foo && python ./test.py
import git
repo = git.Repo.init('foo')
sm_name = 'test'
sm_depth = 1
sm = repo.create_submodule(sm_name, sm_name, url='https://github.com/gitpython-developers/GitPython.git', depth=sm_depth)
print(len(list(sm.module().iter_commits())), sm_depth)
assert len(list(sm.module().iter_commits())) == sm_depth |
Byron
pushed a commit
that referenced
this pull request
May 4, 2020
…and time is previous. Since I could reproduce it and see it working with the steps provided in the comment: #1009 (comment) I think it's good for now. We also assume there won't be a regression.
Member
|
Thanks a lot, especially for making it so easy to reproduce it is indeed working. |
Contributor
Author
|
Great! Thanks for reviewing :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.