Skip to content

Finish typing object, improve verious other types.#1279

Merged
Byron merged 28 commits intogitpython-developers:mainfrom
Yobmod:main
Jun 26, 2021
Merged

Finish typing object, improve verious other types.#1279
Byron merged 28 commits intogitpython-developers:mainfrom
Yobmod:main

Conversation

@Yobmod
Copy link
Contributor

@Yobmod Yobmod commented Jun 25, 2021

This one finished adding types to tree.py so objects folder is done.

Also:

-Add Typedict import and used to improve some Dict types.
-Add Typeguard (Pep647) and start to replace cast() and type: ignores with runtime checks and type narrowing.
-Change typing-extentions dependancy to <py3.10, for Typeguard
-Make IterableList generic and fix all uses to be IterableList[Iterable-type], e.g. IterableList[Head]
-Rename Iterable to IterableObj and changed throughout, due to naming conflic with typing.Iterable. I left git.util.Iterable in place for now and added a deprecationwarning in case users are using it themselves for some reason.

Ready to merge

@Byron Byron added this to the v3.1.19 - Bugfixes milestone Jun 26, 2021
@Byron
Copy link
Member

Byron commented Jun 26, 2021

The work you are doing here is monumental and I am impressed by the consistency with which you chip off little pieces one by one until the mountain is gone.

I also hope that when it's all done you will be open to become a maintainer to keep GitPython operational, I have a feeling that I won't be able to do it in case something breaks when new versions of something break backwards compatibility.

@Byron Byron merged commit 2d2ff03 into gitpython-developers:main Jun 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments