git: index: base: use os.path.relpath#744
Merged
Byron merged 1 commit intogitpython-developers:masterfrom Apr 4, 2018
Merged
Conversation
efiop
force-pushed
the
master
branch
5 times, most recently
from
97164b0 to
176474b
Compare
Codecov Report
@@ Coverage Diff @@
## master #744 +/- ##
==========================================
+ Coverage 94.66% 94.66% +<.01%
==========================================
Files 59 59
Lines 9289 9298 +9
==========================================
+ Hits 8793 8802 +9
Misses 496 496
Continue to review full report at Codecov.
|
Byron
requested changes
Apr 3, 2018
Member
Byron
left a comment
Byron
left a comment
There was a problem hiding this comment.
Thanks a lot for submitting the fix! There is only a minor issue preventing a merge.
Thanks for having a look.
git/test/test_index.py
Outdated
| repo = Mocked() | ||
| path = os.path.join(root, 'file') | ||
| index = IndexFile(repo) | ||
| index._to_relative_path(path) |
Member
There was a problem hiding this comment.
Is there an assertion missing? It looks like _to_relative_path returns the relative path, which is not verified here.
Contributor
Author
There was a problem hiding this comment.
Ah, right. Thank you, fixed in a new version.
Fixes gitpython-developers#743 Signed-off-by: Ruslan Kuprieiev <kupruser@gmail.com>
Member
|
Thanks a lot! Looking good! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #743
Signed-off-by: Ruslan Kuprieiev kupruser@gmail.com