Fix AttributeError when searching a remote by name#862
Fix AttributeError when searching a remote by name#862Byron merged 1 commit intogitpython-developers:masterfrom
AttributeError when searching a remote by name#862Conversation
Byron
left a comment
There was a problem hiding this comment.
It looks like a single test fails, and I would trust that it is indeed genuine.
Maybe you have some ideas why that would be.
Thanks for your help!
|
I just tried that same test on master and I still see the failure. Also, it doesn't touch the |
Running code like `'origin' in git.Repo('path/to/existing/repository').remotes`
raises an AttributeError instead of returning a boolean. This commit fixes that
behaviour by catching the error when doing an identity match on `IterableList`.
Codecov Report
@@ Coverage Diff @@
## master #862 +/- ##
==========================================
+ Coverage 93.6% 94.66% +1.06%
==========================================
Files 59 59
Lines 9769 9389 -380
==========================================
- Hits 9144 8888 -256
+ Misses 625 501 -124
Continue to review full report at Codecov.
|
|
In any case, I've just rebased the branch and it's all green now. |
|
Thanks a bunch! |
Running code like
'origin' in git.Repo('path/to/existing/repository').remotesraises an AttributeError instead of returning a boolean. This commit fixes that
behaviour by catching the error when doing an identity match on
IterableList.Minimum test case with version 2.1.11: