Method stating which commit is being played during an halted rebase#903
Method stating which commit is being played during an halted rebase#903Byron merged 4 commits intogitpython-developers:masterfrom
Conversation
This will be useful to me at least. This way, I know that I can tell my script to omit some specific commits. If you accept to merge it, I may also do similar method for merges and cherry pick.
|
Thanks a lot, good idea! Great you took the extra time to make a contribution. I would happily merge, but believe it needs some work before that could happen.
I understand that this would mean quite some extra work, and hope you can make it work. Besides, I am happily accepting additional quality of life methods if they meet the quality requirements. Thanks for your consideration:) |
Codecov Report
@@ Coverage Diff @@
## master #903 +/- ##
==========================================
- Coverage 94.84% 93.54% -1.31%
==========================================
Files 59 59
Lines 9766 9792 +26
==========================================
- Hits 9263 9160 -103
- Misses 503 632 +129
Continue to review full report at Codecov.
|
|
What do you mean by «both code paths» ? I added a single function, and already added tests for them |
|
The other two requested change are already done |
|
Thanks for the changes. The tests would have to be added in My remark about 'quality of life methods' refers to your comment about adding more methods like this, which I assume are to help you work with GitPython more easily, thus improving your 'quality of life', metaphorically speaking :D. |
|
I added the test in a new file, and forgot to add the file to git. My bad 🈂️ |
|
Thanks a lot for your contribution! That does the trick! |

This will be useful to me at least. This way, I know that I can tell
my script to omit some specific commits. If you accept to merge it, I
may also do similar method for merges and cherry pick.