chore: update system.sh with firestore creds.json path#15599
chore: update system.sh with firestore creds.json path#15599chalmerlowe merged 1 commit intomainfrom
Conversation
This is a blocker for the migration of firestore to this repo. Firestore needs access to a project that has firestore native DBs, which precise-truck-742 does not explicitly have.
Summary of ChangesHello @chalmerlowe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical blocker for the migration of Firestore by configuring the necessary application credentials within the Kokoro build environment. This change ensures that Firestore-related tests, which were previously failing due to missing credentials, can now execute successfully, paving the way for further integration. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
The pull request introduces a new environment variable FIRESTORE_APPLICATION_CREDENTIALS to point to the firebase-credentials.json file. This change is necessary for Firestore migration and fixes failing tests. The change is straightforward and correctly implemented.
This is a blocker for the migration of firestore to this repo. Firestore needs access to a project that has firestore native DBs, which precise-truck-742 does not explicitly have.
Fixes failing tests in #15590 🦕