Skip to content

Comments

chore: update system.sh with firestore creds.json path#15599

Merged
chalmerlowe merged 1 commit intomainfrom
chore-include-firestore-creds-json
Feb 23, 2026
Merged

chore: update system.sh with firestore creds.json path#15599
chalmerlowe merged 1 commit intomainfrom
chore-include-firestore-creds-json

Conversation

@chalmerlowe
Copy link
Contributor

This is a blocker for the migration of firestore to this repo. Firestore needs access to a project that has firestore native DBs, which precise-truck-742 does not explicitly have.

Fixes failing tests in #15590 🦕

This is a blocker for the migration of firestore to this repo.
Firestore needs access to a project that has firestore native DBs, which precise-truck-742 does not explicitly have.
@chalmerlowe chalmerlowe requested review from a team as code owners February 23, 2026 15:55
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chalmerlowe, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical blocker for the migration of Firestore by configuring the necessary application credentials within the Kokoro build environment. This change ensures that Firestore-related tests, which were previously failing due to missing credentials, can now execute successfully, paving the way for further integration.

Highlights

  • Firestore Credentials Setup: Added the FIRESTORE_APPLICATION_CREDENTIALS environment variable to .kokoro/system.sh, pointing to firebase-credentials.json.
Changelog
  • .kokoro/system.sh
    • Added an environment variable for Firestore application credentials.
Activity
  • No specific review comments or activity have been recorded for this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request introduces a new environment variable FIRESTORE_APPLICATION_CREDENTIALS to point to the firebase-credentials.json file. This change is necessary for Firestore migration and fixes failing tests. The change is straightforward and correctly implemented.

@chalmerlowe chalmerlowe merged commit dc85e41 into main Feb 23, 2026
27 checks passed
@chalmerlowe chalmerlowe deleted the chore-include-firestore-creds-json branch February 23, 2026 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants