Skip to content

Add vision label detection#2237

Merged
daspecster merged 1 commit intogoogleapis:masterfrom
daspecster:vision-label-detection
Sep 15, 2016
Merged

Add vision label detection#2237
daspecster merged 1 commit intogoogleapis:masterfrom
daspecster:vision-label-detection

Conversation

@daspecster
Copy link
Contributor

@daspecster daspecster commented Sep 1, 2016 •
edited
Loading

Based off of #2236.

I was able to DRY up the requests code for the EntityAnnotation based detection types.

✅ Waiting for #2236 before rebasing.

@daspecster daspecster added do not merge Indicates a pull request not ready for merge, due to either quality or timing. api: vision Issues related to the Cloud Vision API. labels Sep 1, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 1, 2016
@daspecster daspecster force-pushed the vision-label-detection branch 2 times, most recently from 8395fa7 to c49f0c2 Compare September 12, 2016 14:52
@daspecster daspecster mentioned this pull request Sep 12, 2016
Merged
@daspecster daspecster force-pushed the vision-label-detection branch from c49f0c2 to 8669d3a Compare September 12, 2016 21:58
@daspecster daspecster removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Sep 12, 2016
@daspecster
Copy link
Contributor Author

daspecster commented Sep 13, 2016

@tseaver LMKWYT!

tseaver
tseaver reviewed Sep 14, 2016
View reviewed changes
google/cloud/vision/entity.py Outdated
bounds = Bounds.from_api_repr(response['boundingPoly'])
bounds = []
if 'boundingPoly' in response:
bounds = Bounds.from_api_repr(response['boundingPoly'])

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

tseaver
tseaver reviewed Sep 14, 2016
View reviewed changes
google/cloud/vision/entity.py Outdated
bounds = []
if 'boundingPoly' in response:
bounds = Bounds.from_api_repr(response['boundingPoly'])
bounds = Bounds.from_api_repr(response.get('boundingPoly', {}))

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

google/cloud/vision/geometry.py
vertices.append(Vertex(vertex.get('x', None),
vertex.get('y', None)))
vertices = [Vertex(vertex.get('x', None), vertex.get('y', None)) for
vertex in response_vertices.get('vertices', [])]

This comment was marked as spam.

Sign in to view

@daspecster daspecster force-pushed the vision-label-detection branch from c71fa03 to f75f96d Compare September 14, 2016 19:33
@daspecster
Copy link
Contributor Author

daspecster commented Sep 14, 2016

@tseaver anything else?

@tseaver
Copy link
Contributor

tseaver commented Sep 14, 2016

LGTM pending Travis.

@daspecster daspecster force-pushed the vision-label-detection branch from f75f96d to 408f929 Compare September 14, 2016 20:43
@daspecster
Copy link
Contributor Author

daspecster commented Sep 14, 2016

Squashed...going to wait for travis one more time.

@daspecster daspecster merged commit 143b0a1 into googleapis:master Sep 15, 2016
@dhermes dhermes mentioned this pull request Sep 19, 2016
Merged
@daspecster daspecster deleted the vision-label-detection branch January 24, 2017 15:17
parthea added a commit that referenced this pull request Nov 24, 2025
@parthea
fix: allow google-cloud-documentai 3.x (#2237)
265858d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@tseaver tseaver tseaver left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@tseaver tseaver

Labels

api: vision Issues related to the Cloud Vision API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@daspecster @tseaver @dhermes @googlebot