Correctly clean-up subscription in pubsub system test.#2295
Merged
tseaver merged 1 commit intogoogleapis:masterfrom Sep 10, 2016
Merged
Correctly clean-up subscription in pubsub system test.#2295tseaver merged 1 commit intogoogleapis:masterfrom
tseaver merged 1 commit intogoogleapis:masterfrom
Conversation
googlebot
added
the
cla: yes
Contributor
|
This change is obviously correct: I'd still like to disable that test by default. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Though the most recent build went green, it leaked the subscription (since it was expected to fail, it never reaches the deletion line). This is very much related to #2080.
@tmatsuo Can we actually get a real chat with someone on the eng. team about the value of this system test?