Add GraphQLContext access to ValidationEnvironment#68
Closed
lkorth wants to merge 1 commit intographql-java:masterfrom
Closed
Add GraphQLContext access to ValidationEnvironment#68lkorth wants to merge 1 commit intographql-java:masterfrom
lkorth wants to merge 1 commit intographql-java:masterfrom
Conversation
This allows for access to the current request context making it possible to, for example, write rules that validate based on the current method of authentication.
Author
|
If I rebase this and get it up to date will it be possible to get it reviewed? |
Member
|
Sorry for missing this PR - it was worthwhile See #90 which adds what was here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for access to the current request context making it possible
to, for example, write rules that validate based on the current method
of authentication.
I didn't see any sort of testing around this class and builder, but I'm happy
to add some if needed.