Skip to content

chore!: bump required node version to 16#4972

Merged
jcesarmobile merged 3 commits intonextfrom
node-16
Mar 22, 2023
Merged

chore!: bump required node version to 16#4972
jcesarmobile merged 3 commits intonextfrom
node-16

Conversation

@jcesarmobile
Copy link
Member

No description provided.

Copy link
Contributor

@liamdebeasi liamdebeasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two whitespace fixes, but otherwise this looks good.

jcesarmobile and others added 2 commits March 22, 2023 19:09
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
@jcesarmobile
Copy link
Member Author

I would have expected npm run lint:fix to fix those, but npm run lint just returns true, so it does nothing.
good catch!

@jcesarmobile jcesarmobile merged commit 85fb4fa into next Mar 22, 2023
@jcesarmobile jcesarmobile deleted the node-16 branch March 22, 2023 18:21
liamdebeasi added a commit that referenced this pull request Mar 29, 2023

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
liamdebeasi added a commit that referenced this pull request Mar 29, 2023

Co-authored-by: Liam DeBeasi <liamdebeasi@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants