Add support for adding and clearing multi-valued configuration#1720
Merged
bording merged 3 commits intolibgit2:masterfrom Oct 9, 2019
Merged
Add support for adding and clearing multi-valued configuration#1720bording merged 3 commits intolibgit2:masterfrom
bording merged 3 commits intolibgit2:masterfrom
Conversation
Contributor
Author
|
All green! 👍
|
Contributor
Author
|
heya @bording this PR also gets travis back to green ;) |
Implement value adding by exposing the underlying `set_multivar`, which supports only string values in the underlying libgit2, so no other typed overloads are provided at this point. The counterpart for deleting keys exposes the underlying `delete_multivar`. No regex-based overload is exposed for consistency with the existing `Set<T>` overloads which don't expose it either. Also exposed the boolean return value from the `Unset` calls which is already present in the Proxy API. Fixes libgit2#1719. Fix
This should fix travis failures in CI
bording
requested changes
Oct 8, 2019
Member
bording
left a comment
bording
left a comment
There was a problem hiding this comment.
One minor tweak needed, otherwise LGTM
Co-Authored-By: Brandon Ording <bording@gmail.com>
bording
approved these changes
Oct 9, 2019
Member
|
This change is available in 0.27.0-preview-0024 on nuget.org. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement value adding by exposing the underlying
set_multivar,which supports only string values in the underlying libgit2, so no
other typed overloads are provided at this point.
The counterpart for deleting keys exposes the underlying
delete_multivar.No regex-based overload is exposed for consistency with the existing
Set<T>overloads which don't expose it either.
Also exposed the boolean return value from the
Unsetcalls whichis already present in the Proxy API.
Fixes #1719.