Update git_worktree_add_options struct to include ref pointer#1890
Merged
bording merged 1 commit intolibgit2:masterfrom Jul 3, 2021
Merged
Update git_worktree_add_options struct to include ref pointer#1890bording merged 1 commit intolibgit2:masterfrom
git_worktree_add_options struct to include ref pointer#1890bording merged 1 commit intolibgit2:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1890 +/- ##
=======================================
Coverage 84.61% 84.61%
=======================================
Files 231 231
Lines 9175 9176 +1
=======================================
+ Hits 7763 7764 +1
Misses 1412 1412
Continue to review full report at Codecov.
|
bording
approved these changes
Jul 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a recent upgrade of .netcore to 5.0.7 the WorktreeCollection.Add method has begun failing. Testing against earlier .net versions indicate this was not previously a problem.
Digging around in the lib2git repo shows that this git_worktree_add_options struct actually expects a third property that acts as a pointer to the worktree head.
Where this property gets used we can see where the exception comes from that creates the issue surfaced through libgit2sharp.
When this property isn't included on the struct and zeroed out, the native code presumably (possibly?) finds another value in that memory location that doesn't actually point to anything valid, hence the 💥.
Confirmed as fixed in local testing with different frameworks
Fixes #1885