Conversation
|
@ethomson This PR is trying out updating to libgit2 1.7.1 (previously on 1.6.4), but I'm seeing some potentially unexpected new behavior. One of the tests I've already changed in this PR since it appears libgit2 is returning extensions in a new order. However, the other tests are failing to due changes in the number of tags that are being fetched when the tag fetch mode is either not configured or set to auto. I'm guessing this is related to libgit2/libgit2#6539, but I can't tell if this is an expected behavior change or some sort of bug. In at least one of the failures, it seems like doing the equivalent thing in git itself matches the old behavior that the tests were written against, and not what I'm seeing with 1.7.1. |
|
Aha, I figured it out! Looks like the shallow clone support in 1.7.0 changed After adding that, looks like everything is green now. @ethomson It would probably be a good idea to update the libgit2 v1.7.0 release notes to add that info to the breaking changes section. |
|
Closing this PR in favor of #2066 |
|
Thanks, sorry about that. Indeed that's a breaking ABI change. 🙏 |
No description provided.