Open
Conversation
Member
|
Thanks! I do wonder, isn't this a generated file? Maybe this would need to be fixed also in the original source. I haven't touched this for a while... |
Author
|
Yeah, I thought that too, but don't know the doc generation pipeline. The only other place this sentence appears, as far as I can tell, is in Library/Quaternion.cs, but it seems to be fine there. |
Author
|
@cdrnet so how to we move forward here? I suppose even if this is a generated file, there's no harm in merging the PR. If you'd prefer me to proceed some other way, please let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sure why the diff shows whitespace changes; I didn't touch any other line, so this was probably due to github's editor standardizing the indentation throughout the file.
In any case, the clean diff can be seen here.