feat: add completion cmd for completion integration#701
Merged
max-sixty merged 6 commits intomax-sixty:mainfrom Jan 18, 2026
Merged
feat: add completion cmd for completion integration#701max-sixty merged 6 commits intomax-sixty:mainfrom
max-sixty merged 6 commits intomax-sixty:mainfrom
Conversation
Signed-off-by: Rui Chen <rui@chenrui.dev>
chenrui333
force-pushed
the
add-completion-command
branch
from
ec7200d to
052e0e2
Compare
- Move from top-level `wt completions` to `wt config shell completions` - Remove duplicate CompletionShell enum, use existing Shell enum - Simplify help text to direct users to `wt config shell install` - Remove Homebrew note from FAQ (no duplication issues found) Co-Authored-By: Claude <noreply@anthropic.com>
Add documentation note explaining why static completions are used instead of dynamic completions, and reference the fish example as a potential improvement for future implementation.
Co-Authored-By: Claude <noreply@anthropic.com>
Tests `wt config shell completions <shell>` for all supported shells (bash, fish, zsh, powershell) to satisfy codecov/patch coverage. Co-Authored-By: Claude <noreply@anthropic.com>
Owner
|
thanks a lot @chenrui333 . I made a change to move it below the top level, because I'm very keen to keep the top level very clean. I updated https://github.com/Homebrew/homebrew-core/pull/262653/changes too. Hope that's OK |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @max-sixty