Remove redundant code from getResolvedSignatureWorker#52721
Remove redundant code from getResolvedSignatureWorker#52721Andarist wants to merge 1 commit intomicrosoft:mainfrom
getResolvedSignatureWorker#52721Conversation
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
Andarist
force-pushed
the
cleanup/getResolvedSignatureWorker
branch
from
91adbd2 to
226985f
Compare
|
@typescript-bot user test |
|
Heya @andrewbranch, I've started to run the diff-based top-repos suite on this PR at 226985f. You can monitor the build here. Update: The results are in! |
andrewbranch
left a comment
andrewbranch
left a comment
There was a problem hiding this comment.
getParseTreeNode returns undefined when the input node is transformed. This is here to prevent crashes when API consumers try to do something they shouldn’t do. I think we want to keep it.
|
In such a case, there is no point in this PR. More meaningful changes in this code are happening here anyway |
|
@andrewbranch Here are the results of running the top-repos suite comparing Everything looks good! |
|
@andrewbranch I got curious about this case - is there a way to write a unit~ test that would cover this scenario? 🤔 |
3 participants
while investigating what extra tests I should add as part of #52679 i noticed that some pieces here might not be needed (at least according to the existing test suite)