Remove redundant `getStringLiteralType` call by MichalMarsalek · Pull Request #59803 · microsoft/TypeScript

MichalMarsalek · 2024-08-29T21:28:07Z

Is there a reason for this extra call instead of just using the source type directly? The tests pass the same without it. This was introduced in #47050.

typescript-bot · 2024-08-29T21:28:10Z

This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise.

jakebailey

I'm pretty sure this is correct.

jakebailey · 2025-02-20T00:25:15Z

@typescript-bot test it

typescript-bot · 2025-02-20T00:25:20Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	✅ Results
`user test this`	✅ Started	✅ Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-02-20T00:48:21Z

@jakebailey Here are the results of running the user tests with tsc comparing main and refs/pull/59803/merge:

Everything looks good!

typescript-bot · 2025-02-20T00:51:26Z

Hey @jakebailey, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-02-20T01:10:15Z

@jakebailey
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{194,110k (± 0.95%)}	_{193,023k (± 0.09%)}	_~	_192,940k	_193,360k	_{p=0.378 n=6}
_{Parse Time}	_{1.30s (± 1.51%)}	_{1.31s (± 0.75%)}	_~	_1.30s	_1.33s	_{p=0.152 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.76s (± 0.29%)}	_{9.71s (± 0.45%)}	_~	_9.66s	_9.77s	_{p=0.077 n=6}
_{Emit Time}	_{2.72s (± 1.04%)}	_{2.73s (± 0.75%)}	_~	_2.70s	_2.75s	_{p=0.413 n=6}
_{Total Time}	_{14.50s (± 0.25%)}	_{14.48s (± 0.34%)}	_~	_14.39s	_14.53s	_{p=0.628 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,488	_948,488	_~	_~	_~	_{p=1.000 n=6}
_Types	_411,006	_411,006	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,224,330k (± 0.00%)}	_{1,224,311k (± 0.00%)}	_~	_1,224,286k	_1,224,344k	_{p=0.575 n=6}
_{Parse Time}	_{8.06s (± 0.80%)}	_{8.01s (± 0.52%)}	_~	_7.96s	_8.07s	_{p=0.092 n=6}
_{Bind Time}	_{2.30s (± 0.84%)}	_{2.28s (± 0.70%)}	_~	_2.25s	_2.30s	_{p=0.101 n=6}
_{Check Time}	_{37.96s (± 0.25%)}	_{37.89s (± 0.27%)}	_~	_37.77s	_38.03s	_{p=0.261 n=6}
_{Emit Time}	_{18.35s (± 0.46%)}	_{18.33s (± 0.52%)}	_~	_18.20s	_18.44s	_{p=0.936 n=6}
_{Total Time}	_{66.66s (± 0.19%)}	_{66.52s (± 0.30%)}	_~	_66.19s	_66.74s	_{p=0.298 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,347,891	_2,347,891	_~	_~	_~	_{p=1.000 n=6}
_Types	_845,644	_845,644	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,120,298k (± 0.01%)}	_{2,120,268k (± 0.01%)}	_~	_2,120,170k	_2,120,445k	_{p=0.575 n=6}
_{Parse Time}	_{7.26s (± 0.23%)}	_{7.28s (± 0.27%)}	_~	_7.25s	_7.31s	_{p=0.145 n=6}
_{Bind Time}	_{2.47s (± 0.75%)}	_{2.46s (± 0.79%)}	_~	_2.44s	_2.49s	_{p=0.622 n=6}
_{Check Time}	_{72.48s (± 1.46%)}	_{72.29s (± 1.15%)}	_~	_70.61s	_72.82s	_{p=0.423 n=6}
_{Emit Time}	_{0.14s (± 3.60%)}	_{0.15s (± 2.75%)}	_~	_0.14s	_0.15s	_{p=0.112 n=6}
_{Total Time}	_{82.36s (± 1.28%)}	_{82.17s (± 0.97%)}	_~	_80.56s	_82.67s	_{p=0.471 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,510	_1,228,510	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,960	_266,960	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,358,581k (± 0.01%)}	_{2,358,627k (± 0.02%)}	_~	_2,358,184k	_2,359,183k	_{p=0.936 n=6}
_{Parse Time}	_{5.19s (± 1.25%)}	_{5.22s (± 1.24%)}	_~	_5.12s	_5.29s	_{p=0.378 n=6}
_{Bind Time}	_{1.77s (± 0.97%)}	_{1.78s (± 0.78%)}	_~	_1.75s	_1.79s	_{p=0.565 n=6}
_{Check Time}	_{35.20s (± 0.23%)}	_{35.23s (± 0.33%)}	_~	_35.04s	_35.34s	_{p=0.575 n=6}
_{Emit Time}	_{2.97s (± 1.30%)}	_{2.98s (± 0.55%)}	_~	_2.95s	_2.99s	_{p=0.935 n=6}
_{Total Time}	_{45.15s (± 0.29%)}	_{45.21s (± 0.28%)}	_~	_45.03s	_45.36s	_{p=0.471 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,228,510	_1,228,510	_~	_~	_~	_{p=1.000 n=6}
_Types	_266,960	_266,960	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,426,019k (± 0.02%)}	_{2,426,498k (± 0.06%)}	_~	_2,425,018k	_2,429,286k	_{p=0.810 n=6}
_{Parse Time}	_{5.48s (± 0.53%)}	_{5.48s (± 1.32%)}	_~	_5.38s	_5.56s	_{p=1.000 n=6}
_{Bind Time}	_{1.78s (± 1.40%)}	_{1.79s (± 1.43%)}	_~	_1.76s	_1.82s	_{p=0.564 n=6}
_{Check Time}	_{35.37s (± 0.40%)}	_{35.31s (± 0.41%)}	_~	_35.13s	_35.49s	_{p=0.298 n=6}
_{Emit Time}	_{3.02s (± 0.57%)}	_{3.01s (± 1.74%)}	_~	_2.95s	_3.09s	_{p=1.000 n=6}
_{Total Time}	_{45.65s (± 0.28%)}	_{45.59s (± 0.41%)}	_~	_45.34s	_45.82s	_{p=0.520 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_262,816	_262,816	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,833	_106,833	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{440,518k (± 0.01%)}	_{440,483k (± 0.02%)}	_~	_440,356k	_440,569k	_{p=0.378 n=6}
_{Parse Time}	_{3.56s (± 0.84%)}	_{3.52s (± 1.01%)}	_~	_3.49s	_3.57s	_{p=0.168 n=6}
_{Bind Time}	_{1.30s (± 0.80%)}	_{1.31s (± 0.68%)}	_~	_1.30s	_1.32s	_{p=0.452 n=6}
_{Check Time}	_{18.94s (± 0.22%)}	_{18.91s (± 0.25%)}	_~	_18.87s	_18.98s	_{p=0.297 n=6}
_{Emit Time}	_{1.51s (± 1.49%)}	_{1.53s (± 1.14%)}	_~	_1.51s	_1.56s	_{p=0.145 n=6}
_{Total Time}	_{25.31s (± 0.17%)}	_{25.28s (± 0.28%)}	_~	_25.20s	_25.41s	_{p=0.077 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,113	_226,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,398k (± 0.04%)}	_{371,325k (± 0.02%)}	_~	_371,214k	_371,421k	_{p=0.689 n=6}
_{Parse Time}	_{2.90s (± 0.97%)}	_{2.90s (± 1.36%)}	_~	_2.84s	_2.94s	_{p=0.872 n=6}
_{Bind Time}	_{1.59s (± 2.09%)}	_{1.59s (± 1.46%)}	_~	_1.56s	_1.62s	_{p=0.809 n=6}
_{Check Time}	_{16.48s (± 0.30%)}	_{16.47s (± 0.45%)}	_~	_16.35s	_16.57s	_{p=0.872 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.98s (± 0.38%)}	_{20.96s (± 0.56%)}	_~	_20.76s	_21.09s	_{p=0.936 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₁	₁	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_3,220,984	_3,220,984	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,092,532	_1,092,532	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,296,272k (± 0.01%)}	_{3,296,037k (± 0.01%)}	_~	_3,295,629k	_3,296,299k	_{p=0.173 n=6}
_{Parse Time}	_{14.29s (± 0.37%)}	_{14.24s (± 0.33%)}	_~	_14.17s	_14.31s	_{p=0.127 n=6}
_{Bind Time}	_{4.59s (± 0.64%)}	_{4.61s (± 0.31%)}	_~	_4.59s	_4.63s	_{p=0.089 n=6}
_{Check Time}	_{88.81s (± 1.53%)}	_{89.23s (± 1.64%)}	_~	_88.11s	_91.45s	_{p=0.298 n=6}
_{Emit Time}	_{25.06s (± 8.70%)}	_{26.46s (± 7.99%)}	_~	_23.29s	_28.41s	_{p=0.173 n=6}
_{Total Time}	_{132.75s (± 2.45%)}	_{134.55s (± 2.23%)}	_~	_130.66s	_138.08s	_{p=0.229 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_293,866	_293,866	_~	_~	_~	_{p=1.000 n=6}
_Types	_119,617	_119,617	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{447,170k (± 0.02%)}	_{447,102k (± 0.01%)}	_~	_447,033k	_447,220k	_{p=0.128 n=6}
_{Parse Time}	_{4.09s (± 1.02%)}	_{4.09s (± 1.58%)}	_~	_4.00s	_4.19s	_{p=0.871 n=6}
_{Bind Time}	_{1.76s (± 1.32%)}	_{1.77s (± 0.85%)}	_~	_1.75s	_1.79s	_{p=0.802 n=6}
_{Check Time}	_{18.77s (± 0.45%)}	_{18.71s (± 0.57%)}	_~	_18.58s	_18.82s	_{p=0.298 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.61s (± 0.48%)}	_{24.57s (± 0.61%)}	_~	_24.40s	_24.80s	_{p=0.423 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_558,084	_558,084	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,415	_186,415	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{494,958k (± 0.03%)}	_{495,014k (± 0.01%)}	_~	_494,976k	_495,082k	_{p=1.000 n=6}
_{Parse Time}	_{3.41s (± 0.80%)}	_{3.41s (± 0.54%)}	_~	_3.39s	_3.43s	_{p=0.807 n=6}
_{Bind Time}	_{1.20s (± 0.70%)}	_{1.19s (± 1.54%)}	_~	_1.17s	_1.21s	_{p=1.000 n=6}
_{Check Time}	_{19.77s (± 1.84%)}	_{19.52s (± 0.29%)}	_~	_19.45s	_19.62s	_{p=0.936 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.38s (± 1.45%)}	_{24.12s (± 0.24%)}	_~	_24.05s	_24.19s	_{p=0.568 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-02-20T02:04:03Z

@jakebailey Here are the results of running the top 400 repos with tsc comparing main and refs/pull/59803/merge:

Everything looks good!

remove redundant getStringLiteralType call

de89ee5

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Aug 29, 2024

jakebailey approved these changes Feb 20, 2025

View reviewed changes

jakebailey merged commit d8f6aa7 into microsoft:main Feb 20, 2025

sandersn removed this from PR Backlog Apr 22, 2025

microsoft locked as resolved and limited conversation to collaborators Oct 16, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove redundant `getStringLiteralType` call#59803

Remove redundant `getStringLiteralType` call#59803
jakebailey merged 1 commit intomicrosoft:mainfrom
MichalMarsalek:remove-redundant-getStringLiteralType-call

MichalMarsalek commented Aug 29, 2024

Uh oh!

typescript-bot commented Aug 29, 2024

Uh oh!

jakebailey left a comment

Uh oh!

jakebailey commented Feb 20, 2025

Uh oh!

typescript-bot commented Feb 20, 2025 •

edited

Loading

Uh oh!

typescript-bot commented Feb 20, 2025

Uh oh!

typescript-bot commented Feb 20, 2025

Uh oh!

typescript-bot commented Feb 20, 2025

tsc

Uh oh!

typescript-bot commented Feb 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

MichalMarsalek commented Aug 29, 2024

Uh oh!

typescript-bot commented Aug 29, 2024

Uh oh!

jakebailey left a comment

Choose a reason for hiding this comment

Uh oh!

jakebailey commented Feb 20, 2025

Uh oh!

typescript-bot commented Feb 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

typescript-bot commented Feb 20, 2025

Uh oh!

typescript-bot commented Feb 20, 2025

Uh oh!

typescript-bot commented Feb 20, 2025

tsc

Uh oh!

typescript-bot commented Feb 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typescript-bot commented Feb 20, 2025 •

edited

Loading