Conversation
|
Validation Pipeline Run WinGetSvc-Validation-132-337338-20260207-1 |
There was a problem hiding this comment.
Pull request overview
Adds a new WinGet manifest set for WestWind.DocumentationMonster version 0.4.4.0 under the community repository’s multi-file manifest structure (version/defaultLocale/installer), enabling install/upgrade via winget.
Changes:
- Added the version manifest declaring identifier, version, and default locale.
- Added the defaultLocale manifest with publisher/package metadata and documentation links.
- Added the installer manifest for the Inno Setup installer, including download URL, SHA256, commands, and release date.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| manifests/w/WestWind/DocumentationMonster/0.4.4.0/WestWind.DocumentationMonster.yaml | New version manifest for 0.4.4.0 |
| manifests/w/WestWind/DocumentationMonster/0.4.4.0/WestWind.DocumentationMonster.locale.en-US.yaml | New en-US defaultLocale metadata for 0.4.4.0 |
| manifests/w/WestWind/DocumentationMonster/0.4.4.0/WestWind.DocumentationMonster.installer.yaml | New installer definition (Inno) for 0.4.4.0 |
| - Windows.Desktop | ||
| InstallerType: inno | ||
| InstallModes: | ||
| - silent |
There was a problem hiding this comment.
InstallModes lists only silent, but the schema guidance for the community repo requires installers to support both silent and silentWithProgress. Add silentWithProgress here (and ensure the Inno installer supports it via default behavior or explicit switches).
| - silent | |
| - silent | |
| - silentWithProgress |
| ElevationRequirement: elevatesSelf | ||
| Installers: | ||
| - Architecture: neutral | ||
| InstallerUrl: https://raw-githubusercontent-com-gh.computerqwq.top/RickStrahl/DocumentationMonster/refs/heads/main/Releases/v1/v0.4/DocumentationMonsterSetup-0.4.4.0.exe |
There was a problem hiding this comment.
InstallerUrl points at raw.githubusercontent.com/.../refs/heads/main/..., which is mutable and can change without a version bump. That can break installs (hash mismatch) and reduces supply-chain reliability. Prefer an immutable, versioned download URL (e.g., a tagged GitHub Release asset or vendor-hosted versioned URL).
| InstallerUrl: https://raw.githubusercontent.com/RickStrahl/DocumentationMonster/refs/heads/main/Releases/v1/v0.4/DocumentationMonsterSetup-0.4.4.0.exe | |
| InstallerUrl: https://github.com/RickStrahl/DocumentationMonster/releases/download/v0.4.4.0/DocumentationMonsterSetup-0.4.4.0.exe |
|
Merging failed with:
(Automated response - build 1213.) |
|
Merging failed with:
(Automated response - build 1213.) |
|
Merging failed with:
(Automated response - build 1213.) |
|
Merging failed with:
(Automated response - build 1213.) |
|
Merging failed with:
(Automated response - build 1213.) |
|
Merging failed with:
(Automated response - build 1213.) |
|
Merging failed with:
(Automated response - build 1213.) |
|
Merging failed with:
(Automated response - build 1213.) |
|
Merging failed with:
(Automated response - build 1213.) |
|
Merging failed with:
(Automated response - build 1213.) |
Checklist for Pull Requests
Manifests
winget validate --manifest <path>?winget install --manifest <path>?Note:
<path>is the directory's name containing the manifest you're submitting.Microsoft Reviewers: Open in CodeFlow