Conditionally imports the samples only if its the root project#292
Merged
kpavlov merged 1 commit intomodelcontextprotocol:mainfrom Sep 27, 2025
Merged
Conversation
…ionally include the samples unless its the root project
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR conditionally imports sample projects only when the current project is the root project, preventing unnecessary inclusion of samples when the SDK is used as a dependency in composite builds.
- Adds a conditional check to only include sample builds when
gradle.parent == null - Wraps the existing
includeBuildstatements for three sample projects in the conditional block
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When pulling this project into a composite project, via IncludeBuild, the samples are not necessary nor probably desired. They also cause issues as a transitive dependency
Motivation and Context
Improves the ability to pull the SDK into a composite build
How Has This Been Tested?
yes, tested locally in a composite build
Breaking Changes
N/A
Types of changes
Checklist
Additional context