Refactor testClientConnectWithInvalidJson#338
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the testClientConnectWithInvalidJson test to simplify error handling by replacing a verbose runCatching pattern with a more direct try-finally block using assertFailsWith.
Key Changes:
- Replaced
runCatching().onSuccess().onFailure()chain withtry-finallyblock - Used
assertFailsWith<IllegalStateException>for cleaner assertion of expected exception - Removed unused imports (
TimeoutCancellationException,fail)
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
… with `assertFailsWith` and remove unused imports
devcrocod
force-pushed
the
devcrocod/refactor-testCleitnConnectWithInvalidJson
branch
from
b3d6b2d to
595c07a
Compare
kpavlov
approved these changes
Oct 23, 2025
kpavlov
deleted the
devcrocod/refactor-testCleitnConnectWithInvalidJson
branch
kpavlov
added a commit
that referenced
this pull request
Nov 3, 2025
## Motivation and Context Unifies Ktor library versioning by introducing the Ktor BOM dependency. ## Types of changes - [x] Build configuration update
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
simplification
Breaking Changes
Types of changes
Checklist