Skip to content

fix(tests): replace boolean flag polling with anyio.Event in test_streamable_http #2059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kludex wants to merge 1 commit into from
+7 −5
Closed

fix(tests): replace boolean flag polling with anyio.Event in test_streamable_http #2059

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions tests/shared/test_streamable_http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1232,7 +1232,8 @@ async def test_streamable_http_client_resumption(event_server: tuple[SimpleEvent
captured_resumption_token: str | None = None
captured_notifications: list[types.ServerNotification] = []
captured_protocol_version: str | int | None = None
first_notification_received = False
notification_event = anyio.Event()
resumption_token_event = anyio.Event()

async def message_handler( # pragma: no branch
message: RequestResponder[types.ServerRequest, types.ClientResult] | types.ServerNotification | Exception,
Expand All @@ -1242,12 +1243,12 @@ async def message_handler( # pragma: no branch
# Look for our first notification
if isinstance(message, types.LoggingMessageNotification): # pragma: no branch
if message.params.data == "First notification before lock":
nonlocal first_notification_received
first_notification_received = True
notification_event.set()

async def on_resumption_token_update(token: str) -> None:
nonlocal captured_resumption_token
captured_resumption_token = token
resumption_token_event.set()

# Use httpx client with event hooks to capture session ID
httpx_client, captured_ids = create_session_id_capturing_client()
Expand Down Expand Up @@ -1288,8 +1289,9 @@ async def run_tool():
tg.start_soon(run_tool)

# Wait for the first notification and resumption token
while not first_notification_received or not captured_resumption_token:
await anyio.sleep(0.1)
with anyio.fail_after(5):
await notification_event.wait()
await resumption_token_event.wait()

# Kill the client session while tool is waiting on lock
tg.cancel_scope.cancel()
Expand Down
Loading