Skip to content

fix(tests): remove dead sleep in test_url_elicitation #2060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kludex wants to merge 1 commit into from
+2 −5
Closed

fix(tests): remove dead sleep in test_url_elicitation #2060

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions tests/server/mcpserver/test_url_elicitation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"""Test URL mode elicitation feature (SEP 1036)."""

import anyio
import pytest
from pydantic import BaseModel, Field

Expand Down Expand Up @@ -216,10 +215,8 @@ async def elicitation_callback(context: RequestContext[ClientSession], params: E
assert isinstance(result.content[0], TextContent)
assert result.content[0].text == "Elicitation completed"

# Give time for notification to be processed
await anyio.sleep(0.1)

# Verify the notification was sent
# Verify the notification was sent (flag is set inside the tool handler
# which completes before call_tool returns, so no wait needed)
assert notification_sent


Expand Down