Skip to content

fix(tests): replace sleeps with anyio.Event in test_progress_notifications #2062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Kludex wants to merge 1 commit into from
+12 −4
Closed

fix(tests): replace sleeps with anyio.Event in test_progress_notifications #2062

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions tests/shared/test_progress_notifications.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ async def run_server():
# Track progress updates
server_progress_updates: list[dict[str, Any]] = []
client_progress_updates: list[dict[str, Any]] = []
all_server_progress_received = anyio.Event()

# Progress tokens
server_progress_token = "server_token_123"
Expand All @@ -59,6 +60,8 @@ async def handle_progress(ctx: ServerRequestContext, params: types.ProgressNotif
"message": params.message,
}
)
if len(server_progress_updates) == 3:
all_server_progress_received.set()

# Register list tool handler
async def handle_list_tools(
Expand Down Expand Up @@ -179,8 +182,9 @@ async def handle_client_message(
message="Client progress 100%",
)

# Wait and exit
await anyio.sleep(0.5)
# Wait for all server-side progress updates to arrive, then exit
with anyio.fail_after(5):
await all_server_progress_received.wait()
tg.cancel_scope.cancel()

# Verify client received progress updates from server
Expand All @@ -207,6 +211,7 @@ async def test_progress_context_manager():

# Track progress updates
server_progress_updates: list[dict[str, Any]] = []
all_progress_received = anyio.Event()

progress_token = None

Expand All @@ -220,6 +225,8 @@ async def handle_progress(ctx: ServerRequestContext, params: types.ProgressNotif
"message": params.message,
}
)
if len(server_progress_updates) == 4:
all_progress_received.set()

server = Server(name="ProgressContextTestServer", on_progress=handle_progress)

Expand Down Expand Up @@ -277,8 +284,9 @@ async def handle_client_message(
await p.progress(40, message="Fetching data...")
await p.progress(20, message="Processing results...")

# Wait for all messages to be processed
await anyio.sleep(0.5)
# Wait for all progress updates to arrive, then exit
with anyio.fail_after(5):
await all_progress_received.wait()
tg.cancel_scope.cancel()

# Verify progress updates were received by server
Expand Down